Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3649): Add JSON with dummy data for 'Featured' tab #1408

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat(APP-3649): Add JSON with dummy data for 'Featured' tab #1408

merged 3 commits into from
Oct 25, 2024

Conversation

thekidnamedkd
Copy link
Contributor

Description

Frontrunning the data location by pushing some dummy data into develop

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

cgero-eth
cgero-eth reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the Jira ticket number to the PR name?

src/assets/data/featured.json Outdated Show resolved Hide resolved
src/assets/data/featured.json Outdated Show resolved Hide resolved
src/assets/data/featured.json Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd changed the title feat: Add JSON with dummy data for 'Featured' tab feat(APP-3649): Add JSON with dummy data for 'Featured' tab Oct 25, 2024
cgero-eth
cgero-eth approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thekidnamedkd!

@cgero-eth cgero-eth merged commit 21647a5 into develop Oct 25, 2024
3 checks passed
@cgero-eth cgero-eth deleted the add-featured-json branch October 25, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

@shan8851 shan8851 Awaiting requested review from shan8851

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth