Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APP-3649): Add filters/sort, reorganize layout of buttons #1415

Merged
merged 5 commits into from
Nov 6, 2024
Merged

fix(APP-3649): Add filters/sort, reorganize layout of buttons #1415

merged 5 commits into from
Nov 6, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Nov 6, 2024 •
edited by jira bot
Loading

Description

Re-add filter/sort for 'All DAOs' regardless of connected status

Task: APP-3649

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

shan8851
shan8851 previously approved these changes Nov 6, 2024
View reviewed changes
Copy link

@shan8851 shan8851 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Barukimang
Copy link
Collaborator

LGTM @thekidnamedkd

image

@thekidnamedkd thekidnamedkd merged commit 93e661e into develop Nov 6, 2024
3 checks passed
@thekidnamedkd thekidnamedkd deleted the fix/filter-sort-btns branch November 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barukimang Barukimang Barukimang approved these changes

@shan8851 shan8851 Awaiting requested review from shan8851

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thekidnamedkd @Barukimang @shan8851