Implement toCss utility and fix styles prop
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efoken
force-pushed
the
master
branch
3 times, most recently
from
223007c to
86792d8
Compare
efoken
force-pushed
the
master
branch
3 times, most recently
from
cdb63ae to
904dea7
Compare
efoken
changed the title
csstoCss utility and fix styles prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows using objects for styles with a
toCssutility as an alternative to the template literal as mentioned in #91 (comment).I tried to implement a very basic solution with tiny amount of code. Let me know what you think. Maybe I want to add support for nested objects similar to SCSS, but I'm not sure if that's still needed when nested CSS is starting to get supported by browsers.
This PR also fixes the
styleprop to work like in React, with non-dimensional values – check the tests.