-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic error handling and inclusion of retweet removal with logs #5
base: master
Are you sure you want to change the base?
Conversation
nav clicking on login doesn't always go to login screen but sometimes clicks google signup
update load-data.js to include likes added function to unlike stuff added function to parse more arguments
further expansions made, now handles likes and retweets. |
update readme to reflect changes made fixed small bug in if/else statement in args to allow users to use smaller the 5000ms but still warn them changed the user url from "baruchiro" to "x" just incase Twitter makes an issue of this
update readme to include changes made to further help users understand how to use the program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent some changes here: hybolic#1
Please add them to your Pull Request and I will continue after that.
Thank you!!
i've pushed some changes as per recommendation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code needs more refactor, such as dividing it into functions per sibject (for example- function for likes, function for else, and function for deleting a tweet).
I don't know what is your experties with JS code. If you feel you need help, please let me know. If you feel you can't continue with this, I will continue your work.
Thank you very much!
.action(function(file) { | ||
fileValue = file; | ||
}) | ||
|
||
.option("-d, --debug", | ||
"writes debug information to log file" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The better option in my opinion is to chain all the .option
first, and the .action
will be the last, with all the rest of the code inside it, so you don't need to decalre a global var fileValue
.
const options = await page.waitForSelector('article[data-testid="tweet"][tabindex="-1"] div[aria-label=More]', { | ||
visible: true, | ||
timeout: timeout_amount, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The options
seems to be unused.
# Conflicts: # yarn.lock
# Conflicts: # src/load-data.ts
added some error handling to the deleter
logs made in very basic form
much room for improvement but hopefully this can help someone else