profile menu started #101
profile menu started #101
Conversation
| const onError = (error: any) => { | ||
| console.error(error); | ||
| }; | ||
| const onError = (error: any) => error; |
There was a problem hiding this comment.
What is the reason for this change?
With this change the onError function only returns the error we get from the NuxtErrorBoundary, but we dont do anything with it
There was a problem hiding this comment.
I made these changes to avoid getting the workflow errors! when I do the git push
There was a problem hiding this comment.
Please revert these changes. They are reported as warning by eslint because we use console, but its not an error and this shouldn't stop you from contributing.
@sifferhans Related to #33 - we should define a strategy of how to deal with errors of various kinds.
There was a problem hiding this comment.
Nuxt has a NuxtErrorBoundary component that catches errors from child components, which has a @error event. We could look into using this for client side errors, but we probably need a separate strategy for API errors
There was a problem hiding this comment.
@sifferhans See #33 (comment). We should move this discussion, its off topic here.
|
@sifferhans IMO some of your comments should have gone to a different PR. Most of the changes here were sorely done to reduce the amount of warnings eslint spits out, mostly https://eslint.vuejs.org/rules/attributes-order.html. I've been so free to close these conversations. Because you asked: The event propagation is needed for the |
| const onError = (error: any) => { | ||
| console.error(error); | ||
| }; | ||
| const onError = (error: any) => error; |
There was a problem hiding this comment.
Please revert these changes. They are reported as warning by eslint because we use console, but its not an error and this shouldn't stop you from contributing.
@sifferhans Related to #33 - we should define a strategy of how to deal with errors of various kinds.
pnpm-lock.yaml
Outdated
| @@ -1,3 +1,4 @@ | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Seems like you have not resolved all the merge-conflicts 😅 This file can be reverted and regenerated by running pnpm install...
There was a problem hiding this comment.
The conflict has been resolved now.
| class="absolute right-0 mt-2 w-56 origin-top-right divide-y divide-gray-100 rounded-md bg-white shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none" | ||
| > | ||
| <div class="px-1 py-1"> | ||
| <MenuItem v-slot="{ active }"> |
There was a problem hiding this comment.
All those menu items seem to have the same property. Can't we use a loop here..?
I'd only include options which are done yet or show some kind of message - not something which we are about to implement.
There was a problem hiding this comment.
I just look at the headlessui documentation. I would like also to refact it to have less code. Would you let me know how to do it ?
Also, i've installed nuxt-headlessui module and set it up in nuxt.config.ts file. But i am still getting red line when i am trying to import elements i need for the menu
No description provided.