Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish and persist Profile #310

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Finish and persist Profile #310

merged 12 commits into from
Feb 20, 2024

Conversation

kkuepper
Copy link
Member

  • persist Interface & Content Languages
  • translate
  • hide Autoplay setting
  • match styling with Figma

@kkuepper kkuepper changed the title Finish settings Finish and persist Profile Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 164 lines in your changes are missing coverage. Please review.

Comparison is base (2b26a11) 9.42% compared to head (250b681) 9.03%.
Report is 19 commits behind head on main.

Files Patch % Lines
components/ProfileMenu.vue 0.00% 87 Missing ⚠️
utils/languageDictionary.ts 0.00% 37 Missing and 1 partial ⚠️
utils/availableContentLanguages.ts 0.00% 31 Missing and 1 partial ⚠️
components/dialog/DialogBase.vue 0.00% 2 Missing ⚠️
stores/profile.ts 0.00% 2 Missing ⚠️
utils/getLocalizedLanguageName.ts 0.00% 2 Missing ⚠️
components/TileItem.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #310      +/-   ##
========================================
- Coverage   9.42%   9.03%   -0.40%     
========================================
  Files        110     112       +2     
  Lines       5102    5324     +222     
  Branches     194     196       +2     
========================================
  Hits         481     481              
- Misses      4516    4736     +220     
- Partials     105     107       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-310.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-310.westeurope.3.azurestaticapps.net

Copy link
Collaborator

@SimonSimCity SimonSimCity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just quickly looked over it... Please let me know if I should take some time for a deeper look at it.

utils/availableContentLanguages.ts Show resolved Hide resolved
components/ProfileMenu.vue Show resolved Hide resolved
components/ProfileMenu.vue Outdated Show resolved Hide resolved
components/ProfileMenu.vue Show resolved Hide resolved
components/ProfileMenu.vue Outdated Show resolved Hide resolved
components/ProfileMenu.vue Outdated Show resolved Hide resolved
components/ProfileMenu.vue Outdated Show resolved Hide resolved
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-310.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-310.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-310.westeurope.3.azurestaticapps.net

@kkuepper kkuepper merged commit f90c4fc into main Feb 20, 2024
8 of 10 checks passed
@kkuepper kkuepper deleted the feature/240_settings branch February 20, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants