Small adjustments #362
Small adjustments #362
Conversation
Since the "icon-only" property should only be set when the slot is empty and vv, we can replace it by checking if slot contains a value.
By this we gain route-parameter validation by types.
For the profile-menu, width was replaced by min-width in addition, and the dynamic width does not take the list of content-language, as it can become quite long.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
========================================
- Coverage 8.46% 8.43% -0.03%
========================================
Files 116 116
Lines 6663 6686 +23
Branches 217 217
========================================
Hits 564 564
- Misses 5988 6011 +23
Partials 111 111 ☔ View full report in Codecov by Sentry. |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-362.westeurope.3.azurestaticapps.net |
| if (shuffledTracks) { | ||
| setQueue(shuffledTracks); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
I don't like that every api call needs to be wrapped in a try catch. I'd prefer if we detect the error in the middleware and show a message. Then not every component needs to do it itself.
There was a problem hiding this comment.
That's part of #33. I wouldn't do this in a middleare, because some errors are expected to be handled, others are rather general. I'd rather wrap them all in a wrapper where the caller itself can handle the expected ones and let the wrapper catch all other errors, which should also be reported differently, IMO. That's also why I'm rather against the current implementation of error reporting.
I think this is best to discuss in a meeting on discord.I have quite a distinct meaning about this, but don't know how you've done it in the past.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-362.westeurope.3.azurestaticapps.net |
Just some things I saw could do good of some improvements in the last PRs.
Why I implemented Dynamic width for context menu is best explained in these two screenshots:
Before:
After: