Update VGriveClient.vala #72
Conversation
Experimental changes I made in check_deleted_files function, sync_files and others
src/VGriveClient.vala
Outdated
| EXPERIMENTAL REMOTE CHECKING | ||
| Note: could be incremented checking if the remote file is trased or not. If trashed, exist_remote should be false, otherwise should be true | ||
| */ | ||
| remote_files = this.list_files(-1, lpath, -1); |
There was a problem hiding this comment.
The method list_files returns all the files childs of lpath. Why do you use the list method?
It's more efficient to ask only for the file we are checking with get_file_id instead of listing all the files.
There was a problem hiding this comment.
I put this to try understand better why this delete function is deleting files that exists in both remote and local.
I have 3 guesses:
- Could be the remote checking that don't retrieve the files properly; or
- Could be the local checking that is retrieving the filenames wrong; or
- The escape function that is somehow messing up with the file names.
My thought was try to change the remote checking to make sure it's not it.
I know that is not efficient and I don't want to leave like that, but I want to make sure that the bug keep occurring, so we can put the remote check aside and turn back into get_file_id
Makes sense what I'm trying to do?
There was a problem hiding this comment.
Yes, it make sense.
Where I have got more problems is in the escape function with filenames that have "special" characters. Could you give me some "problematic" filename that you have detected?
There was a problem hiding this comment.
Some special caracters were something like:
~
#
accents in general (á ã õ ó)
But I don't think we need to escape this anymore. I made a lot of changes in the checking functions and seems to work fine with caracters.
There was a problem hiding this comment.
I made some changes, trying to make more consistent deletions on Sync.
With these changes, check_deleted_files() became deprecated, but there is new way to check if the files were deleted.
The functions check_remote_files() and check_local_files() now check if file was deleted or need to upload/download, comparing with the library.
I made a new function delete_files(). It just delete a file and update library. But I'm not sure if I did the library update correctly, if you could check if it's ok I'll be happy! :)
Sync methods working consistently. I reviewed the code and put it to the test. Works fine. * Download new remote files * Upload new local files * Delete files properly * Update library consistently
|
I updated and tested the code. Works fine. |
Nice! I will take a look as sonn as I can! |
|
Looks like patch from this PR does not apply cleanly on 1.6.1 Are you going to updaye that PR? (or remove current on and rediff against 1.6.1) |
Experimental changes I made in check_deleted_files function, sync_files and others