chore(engine): revert rpc-timeout to 2 secs #2366
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
=======================================
Coverage 31.20% 31.20%
=======================================
Files 346 346
Lines 15416 15416
Branches 20 20
=======================================
Hits 4810 4810
Misses 10267 10267
Partials 339 339
|
abi87
commented
Jan 18, 2025
| @@ -29,7 +29,7 @@ import ( | |||
| const ( | |||
| defaultDialURL = "http://localhost:8551" | |||
| defaultRPCRetries = 3 | |||
| defaultRPCTimeout = 900 * time.Millisecond | |||
There was a problem hiding this comment.
this is what we have in Bartio configs
abi87
commented
Jan 18, 2025
| @@ -122,7 +122,7 @@ rpc-dial-url = "http://devnet-blob-eth-val-1:8551" | |||
| rpc-retries = "3" | |||
|
|
|||
| # RPC timeout for execution client requests. | |||
| rpc-timeout = "900ms" | |||
| rpc-timeout = "2s" | |||
There was a problem hiding this comment.
this value gets updated in the file following the new default
abi87
commented
Jan 18, 2025
| @@ -29,7 +29,7 @@ import ( | |||
| const ( | |||
| defaultDialURL = "http://localhost:8551" | |||
| defaultRPCRetries = 3 | |||
| defaultRPCTimeout = 900 * time.Millisecond | |||
| defaultRPCTimeout = 2 * time.Second | |||
There was a problem hiding this comment.
this is the previous default, see https://github.com/berachain/beacon-kit/pull/2362/files#r1921088464
|
Looked at the loki logs from the stress test yesterday and we had this timeout happen only once on a single validator. |
fridrik01
approved these changes
Jan 18, 2025
nidhi-singh02
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to revert the timeout for rpc calls to 2 seconds default.
We adopted the 900ms internal following Bartio configuration but I believe we have no penalties extending this to 2 seconds.
Note that currently CometBFT does not properly clear context in requests (has been long standing request, always de-prioritized in the face of features in higher demand from community)