Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blutgang/nginx from e2e tests and just randomize clients #2371

Open
wants to merge 1 commit into
base: replace-blutgang-with-spamoor-replicas
Choose a base branch
from

Conversation

fridrik01
Copy link
Contributor

This PR updates our e2e tests to randomize calls to execution clients instead of calling them through a load balancer like nging/blutgang.

In our staging env we have had issues with blutgang where it was running unstably and restarting frequently. Also when scanning the blutgang logs it frequently removes nodes from the active set due to them falling behind (and then later adding them back) even if there is almost no load on the network. This resulted in usually always the same node receiving traffic during testing.

This commit updates our e2e tests to randomize calls to exeucion
clients instead of calling them through a load balancer like
nging/blutgang.

In our staging env we have had issues with blutgang where it was
running unstably and restarting frequently. Also when scanning
the blutgang logs it frequently removes nodes from the active
set due to them falling behind (and then later adding them back)
even if there is almost no load on the network.
@fridrik01 fridrik01 self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Project coverage is 31.16%. Comparing base (a6c6111) to head (3cbb0f6).

Files with missing lines Patch % Lines
testing/e2e/suite/setup.go 0.00% 44 Missing ⚠️
testing/e2e/suite/types/execution_client.go 0.00% 41 Missing ⚠️
testing/e2e/suite/types/json_rpc_connection.go 0.00% 24 Missing ⚠️
testing/e2e/suite/suite.go 0.00% 10 Missing ⚠️
testing/e2e/config/defaults.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                             @@
##           replace-blutgang-with-spamoor-replicas    #2371      +/-   ##
==========================================================================
+ Coverage                                   31.15%   31.16%   +0.01%     
==========================================================================
  Files                                         346      345       -1     
  Lines                                       15438    15432       -6     
  Branches                                       20       20              
==========================================================================
  Hits                                         4810     4810              
+ Misses                                      10289    10283       -6     
  Partials                                      339      339              
Files with missing lines Coverage Δ
testing/e2e/config/config.go 0.00% <ø> (ø)
testing/e2e/config/defaults.go 0.00% <0.00%> (ø)
testing/e2e/suite/suite.go 0.00% <0.00%> (ø)
testing/e2e/suite/types/json_rpc_connection.go 0.00% <0.00%> (ø)
testing/e2e/suite/types/execution_client.go 0.00% <0.00%> (ø)
testing/e2e/suite/setup.go 0.00% <0.00%> (ø)

@fridrik01 fridrik01 marked this pull request as ready for review January 18, 2025 18:39
@fridrik01 fridrik01 requested a review from a team as a code owner January 18, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant