fix: Add upper bound validation for MaxWithdrawalsPerPayload #2377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an important security enhancement to the chain specification validation by implementing an upper bound check for MaxWithdrawalsPerPayload. This prevents potential DoS attacks and resource exhaustion that could occur if an extremely large number of withdrawals were allowed per payload.
Changes:
Security Impact:
This change prevents potential DoS attacks by limiting the maximum number of withdrawals that can be processed in a single payload, while still maintaining reasonable operational capacity for the network.
Testing:
The existing test suite covers the validation logic, and the new limit is set to a practical value that shouldn't impact normal operation while preventing abuse.