chore(e2e): Add verification during deposit e2e test #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
- Coverage 26.57% 21.17% -5.40%
==========================================
Files 348 3 -345
Lines 15499 85 -15414
Branches 20 20
==========================================
- Hits 4119 18 -4101
+ Misses 11178 66 -11112
+ Partials 202 1 -201 |
…n-kit into deposit-e2e-verification
shotes
commented
Jan 23, 2025
| @@ -243,7 +243,7 @@ func (s *KurtosisE2ESuite) FundAccounts() { | |||
| gasTipCap, big.NewInt(0).SetUint64(TenGwei)) | |||
| nonceToSubmit := nonce.Add(1) - 1 | |||
| //nolint:mnd // 20000 Ether | |||
| value := new(big.Int).Mul(big.NewInt(20000), big.NewInt(Ether)) | |||
| value := new(big.Int).Mul(big.NewInt(200000), big.NewInt(Ether)) | |||
There was a problem hiding this comment.
More funding to the test accounts. They did not have enough BERA to hit the devnet 4000e9 max effective balance for all 5 validators.
shotes
added
Merge me daddy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strictly correlates the amount of BERA deposited against the amount of validator power and withdrawal balance at the end of the test.
It also modifies the node-api implementation for the validator endpoints. They now return correctly formatted data that works with
go-eth2-client.