Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deposits): Enforce deposit inclusion #2407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shotes
Copy link
Contributor

@shotes shotes commented Jan 24, 2025

This PR enforces that a deposit must be included in the proposed BeaconBlock.

WARNING: I do not believe this is backwards compatible IF a single validator on the chain has ever decided not to include a deposit. Do note that if every single validator so far is using our published binary, this should not be the case and the change should be completely backwards compatible. If this change is to be made, we should either:

  1. Sync a node with this change to the chain to ensure no deposits have been excluded. If there has been a single instance of deposit exclusion, then the sync should fail. In that case, we have to...
  2. Fork it

@shotes shotes requested a review from a team as a code owner January 24, 2025 08:00
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.08%. Comparing base (419cd66) to head (f62217d).

Files with missing lines Patch % Lines
state-transition/core/validation_deposits.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2407   +/-   ##
=======================================
  Coverage   27.08%   27.08%           
=======================================
  Files         351      351           
  Lines       15543    15543           
  Branches       20       20           
=======================================
  Hits         4210     4210           
  Misses      11130    11130           
  Partials      203      203           
Files with missing lines Coverage Δ
state-transition/core/validation_deposits.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@abi87 abi87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will approve as soon as we verify sync is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants