-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replaced user express route by server action #770
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
967700 | Triggered | Username Password | 9908882 | tests/test-user.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
-
Revoke and rotate the secret.
-
If possible, rewrite git history with
git commit --amend
andgit push --force
.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
0645978
to
d807712
Compare
@@ -89,8 +84,6 @@ const startServer = () => { | |||
|
|||
//ROUTES | |||
server.get("/", indexController.getIndex); | |||
server.use(userRouter); | |||
server.use(userApiRouter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a encore besoin de ce fichier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans la première version de la PR je l'avais supprimé. Mais dans cette PR il reste encore les routes badges, je pense faire la suppression définive de express dans une autre PR.
Suppression des apis qui ne sont plus utilisées
Remplacement par des server actions
Où tester les nouvelles serverActions :
il doit y avoir encore des emails disponibles sur betagouv.ovh pour que ça marche