Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaced user express route by server action #770

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

LucasCharrier
Copy link
Contributor

@LucasCharrier LucasCharrier commented Jan 28, 2025

Suppression des apis qui ne sont plus utilisées

  • upgradeEmailForUser
  • deleteEmailForUser

Remplacement par des server actions

  • createRedirectionForUser
  • deleteRedirectionForUser
  • manageSecondaryEmailForUser
  • updatePasswordForUser
  • createEmailForUser

Où tester les nouvelles serverActions :

Copy link

gitguardian bot commented Jan 28, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
967700 Triggered Username Password 9908882 tests/test-user.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@LucasCharrier LucasCharrier force-pushed the task/replace-user-express branch from 0645978 to d807712 Compare January 29, 2025 13:29
@@ -89,8 +84,6 @@ const startServer = () => {

//ROUTES
server.get("/", indexController.getIndex);
server.use(userRouter);
server.use(userApiRouter);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a encore besoin de ce fichier ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans la première version de la PR je l'avais supprimé. Mais dans cette PR il reste encore les routes badges, je pense faire la suppression définive de express dans une autre PR.

@LucasCharrier LucasCharrier changed the title chore: replaced user express by server action chore: replaced user express route by server action Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants