[feat] Addressbook API and more #929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etchegom
commented
Jan 16, 2025
etchegom
changed the title
etchegom
force-pushed
the
feat/addressbook-api
branch
2 times, most recently
from
5c4a6b8 to
9b88bd6
Compare
etchegom
commented
Jan 21, 2025
etchegom
commented
Jan 21, 2025
etchegom
commented
Jan 21, 2025
recoco/rest_api/filters.py
Outdated
Comment on lines
89
to
96
| class WatsonSearchFilter(BaseSearchFilter): | ||
| def filter_queryset(self, request, queryset, view): | ||
| search_terms = " ".join(self.get_search_terms(request)) | ||
| return ( | ||
| watson_search.filter(queryset, search_text=search_terms) | ||
| .annotate(search_rank=F("watson_rank")) | ||
| .filter(search_rank__gte=self.get_search_min_rank(view, request)) | ||
| ) |
There was a problem hiding this comment.
Ca fonctionne avec watson, mais pour le moment je ne sais pas faire:
- booster des champs les uns par rapport aux autres
- ajouter une config "french"
etchegom
commented
Jan 21, 2025
| else: | ||
| search_vector += _vector | ||
|
|
||
| search_query = SearchQuery(search_terms, config="french") |
There was a problem hiding this comment.
Ca serait pas mal d'avoir une config french sans accent.
Ex: https://stackoverflow.com/questions/47230566/using-unaccent-with-searchvector-and-searchquery-in-django
etchegom
force-pushed
the
feat/addressbook-api
branch
2 times, most recently
from
0ac21aa to
934befd
Compare
etchegom
commented
Jan 24, 2025
etchegom
force-pushed
the
feat/addressbook-api
branch
2 times, most recently
from
1523612 to
ec58903
Compare
etchegom
force-pushed
the
feat/addressbook-api
branch
from
c8e796b to
07fda9a
Compare
glibersat
reviewed
Jan 28, 2025
recoco/rest_api/permissions.py
Outdated
| from recoco.utils import is_staff_for_site | ||
|
|
||
|
|
||
| class IsStaff(BasePermission): |
There was a problem hiding this comment.
ça pourrait être pas mal de l'appeler IsStaffForSite pour éviter les confusion avec Staff Recoco
|
|
||
|
|
||
| class VectorSearchFilter(BaseSearchFilter): | ||
|
|
There was a problem hiding this comment.
Pourrais tu documenter en quelques mots ce que ça fait stp ?
Louifine
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il s'agit de :
Décrivez vos changements
OrganizationGroupTaskFollowupet modification des payload liésNotes:
Checklist d'acceptation de revue de code
Demandes