🚧 Nouvelles conversations unifiées #944
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New view - New template WIP
- redirect to new conversatino if posted message with new=1 query param in GET - beginning of full feed
…uv/recommandations-collaboratives into feature/new-conversations
…uv/recommandations-collaboratives into feature/new-conversations
etchegom
reviewed
Jan 27, 2025
Comment on lines
+293
to
+298
| project = get_object_or_404( | ||
| models.Project.objects.filter(sites=request.site).with_unread_notifications( | ||
| user_id=request.user.id | ||
| ), | ||
| pk=project_id, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| project = get_object_or_404( | |
| models.Project.objects.filter(sites=request.site).with_unread_notifications( | |
| user_id=request.user.id | |
| ), | |
| pk=project_id, | |
| ) | |
| project = get_object_or_404( | |
| models.Project.objects.filter(sites=request.site).with_unread_notifications( | |
| user_id=request.user.id | |
| ).select_related("commune__department"), | |
| pk=project_id, | |
| ) |
etchegom
reviewed
Jan 27, 2025
recoco/apps/projects/views/detail.py
Outdated
|
|
||
| feed.sort(key=lambda x: x["timestamp"]) | ||
|
|
||
| return render(request, "projects/project/conversations_new.html", locals()) |
There was a problem hiding this comment.
Je me permets de remettre en question l'usage de locals. Pourquoi veut on passer toutes ces données aux templates?
etchegom
reviewed
Jan 27, 2025
|
|
||
| advising = get_advisor_for_project(request.user, project) | ||
|
|
||
| is_regional_actor or has_perm_or_403(request.user, "view_public_notes", project) |
There was a problem hiding this comment.
On peut faire remonter has_perm_or_403 en haut de cette fonction, pour éviter de faire des requêtes si on est dans un cas de 403
- Add topic field to `Note` model - add "topic" field to feed data structure in new conversation view - make use of new field by regrouping by it
…ivities to pevent duplicates
- Merge branches - Add tests - Add "topic_name" as an optional argument for POST while creating a public note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il s'agit de :
Décrivez vos changements
Prototypage des nouvelles conversations unifiées
Checklist d'acceptation de revue de code
Demandes