Fix NR Adjustments

[jsphon]

This is just a preliminary PR for the time being.

1 Implementing the alternative way of adjusting place markets.
2 If LAY limit orders have persistence type MARKET_ON_CLOSE, the remaining portion are convert to MARKET_ON_CLOSE orders.

Will the simulated profit on bets from (2) be calculated correctly if there is both a partial fill before the NR adjustment, a remaining portion converted to MARKET_ON_CLOSE?

[liampauling]

Do you have any example pnl screenshots of place markets where a NR has occurred?

[jsphon]

Will this do?

[liampauling]

Has this been implemented?

Other differences of 'Place' markets:
All reduction factors will be applied (2.5% or less included)
Only if the reduction factor for a withdrawn horse is 4.0% or greater, all unmatched lay bets will be cancelled.

[jsphon]

Has this been implemented?

Other differences of 'Place' markets:
All reduction factors will be applied (2.5% or less included)
Only if the reduction factor for a withdrawn horse is 4.0% or greater, all unmatched lay bets will be cancelled.

Good point. I didn't notice that bit. I've pushed change to address that.

[liampauling]

Don't we already handle this on line 117?

[jsphon]

I don't think so.

On line 174, the Order Type will be LIMIT_ON_CLOSE or LIMIT if the order's a LAY.

On line 117, the Order Type is MARKET_ON_CLOSE for LAY bets.