-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/parallel multi event simulation #687
base: master
Are you sure you want to change the base?
Feature/parallel multi event simulation #687
Conversation
Any reason why you used this design market_filter={"markets": [..], "event_processing": True, "event_groups": {"123": "A", "456": "A"}} rather than: market_filter={"markets": [..], "event_processing": True, "event_groups": {"A": ["123", "456"]}} |
My original intention was to name the feature "event_aliases" so that, for example, a forecast event ID is converted to the event ID of win/place markets. However, I thought that "event_groups" might be more descriptive and less confusing to work with. I see two advantages of the dict approach over the list one:
|
Resolved merge conflicts with master. |
@liampauling So what do you want to do regarding this PR? Do you want me to update the API as you proposed or do you want to accept it as it is? |
I have implemented a feature which allows parallel simulation of multiple events by assigning them execution groups via
event_groups
argument to the market filter. Execution groups replace event ids in the simulated framework so that any combination of events can be executed in parallel, not just one event at a time. However, ifevent_groups
mapping is not provided, event group defaults to event id, so the legacy event processing behaviour remains unchanged.Example usage here:
https://github.com/mzaja/flumine/blob/34136cbbaa31b4d27b18e38bf8cbd7f25bcc998a/docs/quickstart.md?plain=1#L219-L224