Adding the --from option to bigmler whizzml to store packages locally #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaor
approved these changes
Apr 4, 2024
| @@ -43,6 +43,14 @@ def get_whizzml_options(defaults=None): | |||
| "default": defaults.get('upgrade', False), | |||
| "help": "Create resource only if it doesn't exist."}, | |||
|
|
|||
| # export script or library to be stored in a package directory | |||
| '--from': { | |||
There was a problem hiding this comment.
not sure about this, but perhaps something more descriptive like "--import-package" or "--import" would be better? no strong opinion if you like the pithy "--from" though.
There was a problem hiding this comment.
Oh, I actually thought about "--export" as it is exporting the info from the platform, but I thought that was rather a verb than an option. That's why I used "--from"
|
On Thu, Apr 04 2024, Mercè Martín-Prats wrote:
Oh, I actually thought about "--export" as it is exporting the info
from the platform, but I thought that was rather a verb than an
option. That's why I used "--from"
oh, i wasn't aware of that convention. if --from is then more
consistent, that's a good reason to use it. if nouns are "options",
another possibility would be --origin(_id), or even --script(_id), but i
am thinking that one will have to check the docs anyway to discover
them, so i suppose we might as well keep the shorter --from.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.