Fix incomplete onEvent payload on iOS
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
force-pushed
the
fix-onEvent-payload-on-iOS
branch
from
e67d250 to
ac4b48d
Compare
rolandkakonyi
changed the title
onEvent payload on iOSonEvent payload on iOS
Co-authored-by: Mr. Graf <pleaselou@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onEventlistener receives onlynameandtimestampproperties as its payload, regardless of the actual event.Changes
The problem is that functions declared in extensions in Swift don't support runtime polymorphism, therefore when calling
event.toJSON()wheneventhas typeEvent, it will invoke the one fromextension Event, not the actual type's implementation.To address this I made the JSON serialization protocol-based, thus enabling runtime dynamic dispatch for method calls, resulting in runtime polymorphism.
At I implemented the same approach as we have for Android, with
JSONConverter, but that way we would lose the ability to detect missing event serialization during compilation when new events are introduced.Checklist
CHANGELOGentry