-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player testing: host app setup #330
Player testing: host app setup #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default contents of the template application.
This is changed in #332
…player-testing/integration-test-app-setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly that we need another "app", but kinda makes sense given the setup RN is following.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this will then be filled with instructions on the e2e tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am working on that!
@matamegger we don't "need", BUT I chose to, in order to avoid additional changes to the example app for the sake of testing. Especially as we reference it in our guides, it could confuse readers. |
I very much approve the separation of example and test setup here (well done 👍 ). |
To be complete, I add more details here: |
Description
To enable running integration tests, we need an application to run on our supported platforms.
Changes
Created a new application using the react native command line tools and manually adapted it to have the same extra changes as we have for the example app.
No other changes were made.
Also updated ignore files accordingly.
I went for creating a new application and keeping the example application untouched as I wanted to have the example application's changes and test host app changes separated.
Note: further changes to enable player testing come in upcoming PRs.
Checklist
CHANGELOG
entry - not applicable, we should add a single entry once everything gets merged for integration testing