Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player testing: host app setup #330

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

rolandkakonyi
Copy link
Contributor

@rolandkakonyi rolandkakonyi commented Nov 24, 2023

Description

To enable running integration tests, we need an application to run on our supported platforms.

Changes

Created a new application using the react native command line tools and manually adapted it to have the same extra changes as we have for the example app.
No other changes were made.
Also updated ignore files accordingly.

I went for creating a new application and keeping the example application untouched as I wanted to have the example application's changes and test host app changes separated.

Note: further changes to enable player testing come in upcoming PRs.

Checklist

  • 🗒 CHANGELOG entry - not applicable, we should add a single entry once everything gets merged for integration testing

@rolandkakonyi rolandkakonyi self-assigned this Nov 24, 2023
@rolandkakonyi rolandkakonyi changed the title Player testing host app setup Player testing: host app setup Nov 24, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default contents of the template application.
This is changed in #332

@rolandkakonyi rolandkakonyi marked this pull request as ready for review November 27, 2023 08:22
Copy link
Contributor

@matamegger matamegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly that we need another "app", but kinda makes sense given the setup RN is following.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will then be filled with instructions on the e2e tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am working on that!

@rolandkakonyi
Copy link
Contributor Author

Interestingly that we need another "app", but kinda makes sense given the setup RN is following.

@matamegger we don't "need", BUT I chose to, in order to avoid additional changes to the example app for the sake of testing. Especially as we reference it in our guides, it could confuse readers.

@matamegger
Copy link
Contributor

Interestingly that we need another "app", but kinda makes sense given the setup RN is following.

@matamegger we don't "need", BUT I chose to, in order to avoid additional changes to the example app for the sake of testing. Especially as we reference it in our guides, it could confuse readers.

I very much approve the separation of example and test setup here (well done 👍 ).
My interest was towards the need for an actual app with UI, instead of something more low profile like it can be done in the native android ecosystem for instance. But as said, it makes sense in the context of RN.

Base automatically changed from PRN-66/update-react-native-to-the-latest-version to development December 12, 2023 16:33
@rolandkakonyi
Copy link
Contributor Author

Interestingly that we need another "app", but kinda makes sense given the setup RN is following.

@matamegger we don't "need", BUT I chose to, in order to avoid additional changes to the example app for the sake of testing. Especially as we reference it in our guides, it could confuse readers.

I very much approve the separation of example and test setup here (well done 👍 ). My interest was towards the need for an actual app with UI, instead of something more low profile like it can be done in the native android ecosystem for instance. But as said, it makes sense in the context of RN.

To be complete, I add more details here:
For Google IMA we need a UI stack, as the iOS Google IMA SDK needs a view to host the ad contents and UI. Additionally, DRM playback also requires a view stack where it renders, as we have seen failures in the past with DRM playback and no UI.

@rolandkakonyi rolandkakonyi merged commit d8a6d02 into development Dec 13, 2023
8 checks passed
@rolandkakonyi rolandkakonyi deleted the player-testing/integration-test-app-setup branch December 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants