Player testing: Cavy framework setup #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
commented
Nov 25, 2023
Comment on lines
+10
to
+12
| "pods": "yarn pods-install || yarn pods-update", | ||
| "pods-install": "yarn pod-install", | ||
| "pods-update": "pod update --silent" |
There was a problem hiding this comment.
These were moved here from the root package.json to separate concerns
rolandkakonyi
commented
Nov 25, 2023
integration_test/babel.config.js
Outdated
There was a problem hiding this comment.
Changes here mirror the one from the example app
rolandkakonyi
commented
Nov 25, 2023
integration_test/src/TestableApp.tsx
Outdated
There was a problem hiding this comment.
This has a very basic setup which gets modified for actual player testing in #332
rolandkakonyi
commented
Nov 25, 2023
There was a problem hiding this comment.
This is a placeholder test to prove the framework works
rolandkakonyi
commented
Nov 25, 2023
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
We have to install yarn dependencies for the integration tests as well to allow typescript related validation.
matamegger
approved these changes
Nov 28, 2023
Co-authored-by: Matthias Tamegger <matamegger@users.noreply.github.com>
Co-authored-by: Matthias Tamegger <matamegger@users.noreply.github.com>
…testing/cavy-setup
Base automatically changed from
player-testing/integration-test-app-setup
to
development
December 13, 2023 07:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to enable writing integration tests, we need a framework that can run tests, that runs them on the native platform (unlike Jest), and has access to code-level components, such as
Player.After an initial investigation, I found https://github.com/pixielabs/cavy.
Note: I noticed there were no commits in the last ~2 years, BUT no other solution I found had the characteristics we needed. At the same time, I familiarized myself with their codebase, which isn't too complex, nor too big, therefore forking and fixing issues, or implementing features shouldn't be too hard.
(I already opened a PR for fixing a race condition)
Changes
Integrated Cavy into the integration test application and set it up with a basic setup that can be extended to have player integration tests.
Checklist
CHANGELOGentry - not applicable, we should add a single entry once everything gets merged for integration testing