Feat/initial bandwidth estimate override #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2024 12:10
updated with commits in development
krocard
approved these changes
Aug 28, 2024
| @@ -144,6 +144,7 @@ private fun String.toTimelineReferencePoint(): TimelineReferencePoint? = when (t | |||
| */ | |||
| private fun ReadableMap.toAdaptationConfig(): AdaptationConfig = AdaptationConfig().apply { | |||
| withInt("maxSelectableBitrate") { maxSelectableVideoBitrate = it } | |||
| withInt("initialBandwidthEstimateOverride") { initialBandwidthEstimateOverride = it.toLong(); } | |||
There was a problem hiding this comment.
JS number is a double. Not sure why this is an Int 🤔 Should both be changes to withDouble?
There was a problem hiding this comment.
Good point; thank you.
OK if I'll leave it as-is for now please as this seems inline with the withInt implementation of both bandwidthEstimateWeightLimit and maxSelectableBitrate
strangesource
approved these changes
Aug 28, 2024
src/adaptationConfig.ts
Outdated
| * The initial bandwidth estimate in bits per second the player uses to select the optimal media tracks before actual bandwidth data is available. Overriding this value should only be done in specific cases and will most of the time not result in better selection logic. | ||
| * | ||
| * @platform Android | ||
| * @see https://cdn.bitmovin.com/player/android/3/docs/player-core/com.bitmovin.player.api.media/-adaptation-config/initial-bandwidth-estimate-override.html?query=var%20initialBandwidthEstimateOverride:%20Long? |
There was a problem hiding this comment.
Suggested change
| * @see https://cdn.bitmovin.com/player/android/3/docs/player-core/com.bitmovin.player.api.media/-adaptation-config/initial-bandwidth-estimate-override.html?query=var%20initialBandwidthEstimateOverride:%20Long? | |
| * @see https://cdn.bitmovin.com/player/android/3/docs/player-core/com.bitmovin.player.api.media/-adaptation-config/initial-bandwidth-estimate-override.html |
Actually not sure if this is very helpful. The documentation here is the same as the linked one. I would suggest to not include the link, also as it could get outdated.
Co-authored-by: Kevin Rocard <kevin.rocard@bitmovin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the
adaptationConfig.initialBandwidthEstimateOverrideconfig parameter.Changes
Android initialBandwidthEstimateOverride is type Long. No such type on JS hence converted from int to long. Hope that's ok. Max value of Int
2,147,483,647should be sufficient for this usecase I believe.Checklist
CHANGELOGentry