Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling for the initially displayed CEA-608 cue #666

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

felix-hoc
Copy link
Contributor

@felix-hoc felix-hoc commented Jan 8, 2025

Description

Issue: PW-22216

When enabling CEA captions within the time range of a cue, this cue is not styled as expected.

This is because we reset the CEA caption setup (mainly adding a cea-608 class to the subtitle overlay that causes caption styling to be applied) on a subtitleenabled event. The CEA caption setup gets done on a cueenter event, but that one may arrive before.

The event flow is as follows:

  1. subtitleenable
  2. cueenter
  3. subtitleenabled

Thus, we should reset the CEA caption setup on subtitleenable, to get a clean slate for whatever subtitle format arrives in the following cueenter.

Furthermore, there was a slight issue with vertical alignment of caption cues when the player size was rather small.

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@felix-hoc felix-hoc changed the title Fix unexpected reset of CEA caption setup when enabling captions Fix unexpected styling for the initially displayed CEA-608 cue Jan 8, 2025
@felix-hoc felix-hoc changed the title Fix unexpected styling for the initially displayed CEA-608 cue Fix styling for the initially displayed CEA-608 cue Jan 8, 2025
Copy link
Contributor

@bitmovin-kenny bitmovin-kenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-hoc felix-hoc marked this pull request as ready for review January 8, 2025 13:26
@felix-hoc felix-hoc merged commit 86e7958 into develop Jan 8, 2025
3 checks passed
@felix-hoc felix-hoc deleted the feature/fix-cea-initial-cue-styling branch January 8, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants