Automatically resolve TV UI when using full UI #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
commented
Jan 13, 2025
src/ts/uifactory.ts
Outdated
| @@ -669,3 +681,8 @@ function tvUILayout() { | |||
| spatialNavigation: spatialNavigation, | |||
| }; | |||
| } | |||
|
|
|||
| function tvAdsUILayout() { | |||
| // TODO: implement once we have a design for TV ads | |||
There was a problem hiding this comment.
It will be implemented once the Design is finalized.
stonko1994
changed the title
Base automatically changed from
feature/get-rid-of-modern-and-default
to
feature/modern-ui-base
January 14, 2025 07:43
felix-hoc
reviewed
Jan 14, 2025
felix-hoc
approved these changes
Jan 14, 2025
src/ts/browserutils.ts
Outdated
Comment on lines
51
to
52
| return this.isHisense || this.isPlayStation || this.isWebOs | ||
| || this.isTizen || this.isVizio || this.isXumo || this.isXbox; |
There was a problem hiding this comment.
we could also check for VIDAA OS:
/VIDAA/.test(navigator.userAgent);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Our TV UI does not automatically apply when running the Player/UI unmodified on a TV platform.
Changes
Automatically resolving to the TV UI variant when running on a TV platform.
isTvto theUIConditionContext