Add empty state UI #674
Merged
Add empty state UI #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/auto-resolve-tv-ui
to
feature/modern-ui-base
January 14, 2025 12:53
dweinber
reviewed
Jan 15, 2025
dweinber
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
When the initial source loading takes longer than loading the UI, the values displayed by the UI are fallback values. Usually it shows a duration of
00:00and a current time of00:01. This is particular problematic when the stream is actually a live stream.Changes
To prevent this issue we add an empty state UI with only the
PlaybackToggleButton,Buffering-andErrorOverlay. This improves the initial UI displayed in case no Source is loaded yet.