Support for customizing the font style and character edge color of subtitles/captions #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
approved these changes
Jan 15, 2025
src/scss/skin-modern/_mixins.scss
Outdated
| @@ -144,3 +144,19 @@ | |||
| outline: none; | |||
| } | |||
| } | |||
|
|
|||
| /// Replace `$search` with `$replace` in `$string`. From https://css-tricks.com/snippets/sass/str-replace-function/ | |||
| /// @author Kitty Giraudel | |||
There was a problem hiding this comment.
Do we want to keep this?
There was a problem hiding this comment.
I thought it would be nice to keep the attribution. But the link alone could also be sufficient. What's your preference?
There was a problem hiding this comment.
I don't have a strong opinion. Both works for me 👍
src/ts/components/subtitlesettings/characteredgecolorselectbox.ts
Outdated
Show resolved
Hide resolved
|
Thanks!
That would be good if someone could do that 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current subtitle/caption styling did not allow for changing the font style (default, italic, bold) and the character edge color. These two options are now added as well.
Checklist (for PR submitter and reviewers)
CHANGELOGentry