Epub documents chapters will be ordered according to the document's spine where applicable #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I'll try as soon as it builds but your appveyor build failed. can you check? Thanks. |
|
@pauliyobo |
|
Any news on this issue? Is there some input you need from me to generate
the build?
El lun, 22 ene 2024 a las 2:53, Rowen ***@***.***>) escribió:
… @pauliyobo <https://github.com/pauliyobo>
Can you fix the build error?
—
Reply to this email directly, view it on GitHub
<#246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4P75KL2EF4HXY5E6WSKZLYPXBC5AVCNFSM6AAAAABB7J7VQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSHA3TSMBVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* Added github actions * Fixed typo * Fixed typo * Added python encoding * Trying to optimize build * Added nsis github action * Removed makensis action * Naming installer * Testing release workflow * fixed indentation * Downloading all artifacts * Added invoke to dependencies * Caching dependencies * Modified cache key * Incorrectly set up virtual env * Fixing sintax error * Activating virtual environment in other steps * Trying to fix caching * Merging two steps into one because of venv * Trying to fix deploy job * Fixed cache key * Moving instead of copying * Updated zip steps * Adding version-information and translation catalogs * Fixed oversight * Fixed typo * added distinct globs for other extension types * Mistaked directory * Made code more readable * feat: Added test job * fix: Fixed test job * Fix: Fixed indentation * feat: Added pytest.ini configuration * Using invoke in dependencies job * Added invoke * Updated github actions versions * Updated cache * Uploading release-info only when a release will be generated * Handling error when zipping artifacts
|
This build fails because it can't find 2in32api, for some reason.
Unhandled exception in script.
Traceback (most recent call last):
File
"Lib\site-packages\PyInstaller\hooks\rthooks\pyi_rth_win32comgenpy.py",
line 46, in <module>
File
"Lib\site-packages\PyInstaller\hooks\rthooks\pyi_rth_win32comgenpy.py",
line 25, in _pyi_rthook
File "PyInstaller\loader\pyimod02_importers.py", line 385, in exec_module
File "win32com\__init__.py", line 9, in <module>
ImportError: DLL load failed while importing win32api: No se encontró el
proceso especificado.
that last bit translates to the typical OSError when a process isn't found.
El dom, 28 ene 2024 a las 23:08, Paul Iyobo ***@***.***>)
escribió:
… Hello
I apologize for the delay, it has been a busy week at work.
@ogomez92 <https://github.com/ogomez92> now that #234
<#234> has been merged you
can grab the artifacts from the actions page. Please let me know if it
works on your end as well before I merge.
—
Reply to this email directly, view it on GitHub
<#246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4P75LCUDTM6DJGRLJBPVDYQ3D5TAVCNFSM6AAAAABB7J7VQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTG4ZTOMZVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
06 El_vuelo_del_angel_Michael_Connelly.zip Thanks. |
|
Hello. Do you mean the first file? I happen to have lost it, would you mind providing another link? |
|
no I mean the file I attached to my previous comment.
https://drive.oriolgomez.com/f/19fdced667c142cab042/
https://drive.oriolgomez.com/f/19fdced667c142cab042/
El lun, 29 ene 2024 a las 12:22, Paul Iyobo ***@***.***>)
escribió:
… Hello. Do you mean the first file? I happen to have lost it, would you
mind providing another link?
Thanks.
—
Reply to this email directly, view it on GitHub
<#246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4P75MOCFUMDJIENYCUTJ3YQ6A7FAVCNFSM6AAAAABB7J7VQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGQ4DQNRRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you. Can you try now? You'll have to clear the cache again. |
|
Hello, |
|
Hi.
All is well now, it works perfectly.
El lun, 5 feb 2024 a las 21:36, Paul Iyobo ***@***.***>)
escribió:
… Hello,
@ogomez92 <https://github.com/ogomez92> just checking to understand if
the PR solves your issue or if there are still things that don't work.
—
Reply to this email directly, view it on GitHub
<#246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4P75J4OGNBEJJMYKLEIXDYSE7GXAVCNFSM6AAAAABB7J7VQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRYGA2TEMBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #243
Summary of the issue:
Basically whenever an epub document would have chapters with, say, a different naming scheme, such as roman numbers, their order would be totally inconsistent with what the result should be.
Description of how this pull request fixes the issue:
Since epub chapters are files in a folder, their current order would follow the OS filesystem ordering scheme rather than the book.
This PR essentially compares the files to be included in the book to render and if necessary they are adjusted according to the spine structure, which we always assume to be correct.
Testing performed:
Unit tests
Known issues with pull request:
None
@ogomez92 would you mind trying this version as soon as it builds?
You will probably have to clear the document cache for the fix to take effect.
Also, in the testsuite I have added the roman.epub file you attached in the issue. If this is a problem, please let me know and I will find something else to use instead.