-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated SQLAlcjhemy to 2.x and introduced alembic for automatic migrations #273
Conversation
Great, although I haven't looked carefully yet, I think, we can fix the build error first |
The build error seems to be fixed. The extra check seems to be related to appveyor, which we no longer rely on. |
No, I see the appveyor build is not successful, you can check the log. The artifacts generated by Github Action are only 200+kb: https://github.com/blindpandas/bookworm/actions/runs/10986077248 |
Hi @pauliyobo |
Hello |
Hi @pauliyobo
|
Hello @cary-rowen |
Hi @pauliyobo |
Hi @pauliyobo thank you for your work |
Hello. |
LGTM, I think we can continue. |
This PR basically allows us to no longer have to keep track of schema versions, since by having alembic running migrations automatically, that'd be done for us. I'm using this as a base in order to implement DB related changes that may solve issues such as #229, #205, and potentially #210
It started as a PR which would target only the integration with alembic, but I had to also upgrade certain PyInstaller tasks, given that the final executable layout has changed ever since v6.x was released.
@mush42 @cary-rowen any potential things I might be missing?
I'd like to keep the context of this PR as small as possible, given that I've already made it quite broad already