feat: allow extra args to be passed to nextjs cli #4252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63dc838 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
flybayer
reviewed
Dec 6, 2023
Comment on lines
+20
to
+28
| const extraArgs = nextArgs["_"].filter((arg) => arg !== "start") | ||
|
|
||
| const config: ServerConfig = { | ||
| rootFolder: process.cwd(), | ||
| port: nextArgs["--port"], | ||
| hostname: nextArgs["--hostname"], | ||
| inspect: nextArgs["--inspect"], | ||
| env: process.env.NODE_ENV === "production" ? "prod" : "dev", | ||
| extraArgs, |
There was a problem hiding this comment.
hey thank you! Been wanting this for awhile.
Few things
- we need to make sure extraArgs is not also including ones we explicitly use (like
--inspect) - we should remove our use of
--hostnameand--portwhile we are here, they are legacy and no longer needed
There was a problem hiding this comment.
hi @julianklumpers, are you able to make these changes?
There was a problem hiding this comment.
yes, sorry for my late reply. Will try to implement this very soon.
|
Hey, I'm going to close this for now as it's gone cold. Feel free to fix and re-open :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: -
What are the changes and their implications?
Allow extra args to be passed to the nextjs CLI. For example in my case:
blitz dev -p 3000 --experimental-https. The--experimental-httpswill be passed down to he nextjs cli.Bug Checklist
pnpm changesetin the root directory)Feature Checklist
pnpm changesetin the root directory)mainbranch)