-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor jointBayesNet #1991
Refactor jointBayesNet #1991
Conversation
dellaert
commented
Jan 23, 2025
- Found we computed too much in jointBayesNet
- Refactored it with two helper methods
- exposed more DiscreteBayesTree methods in wrapper
Thanks for the review. I'll incorporate the doc changes in a follow-up PR to avoid another CI. |
I recommend doing it here so that it's all together if we ever have to come back to this PR. The cost of an extra CI run is not as bad as training LLMs these days. :) |
I already did it in a follow up PR. Please approve so I can move on |