Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor jointBayesNet #1991

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Refactor jointBayesNet #1991

merged 8 commits into from
Jan 24, 2025

Conversation

dellaert
Copy link
Member

  • Found we computed too much in jointBayesNet
  • Refactored it with two helper methods
  • exposed more DiscreteBayesTree methods in wrapper

@dellaert dellaert requested a review from varunagrawal January 23, 2025 04:52
@dellaert
Copy link
Member Author

Thanks for the review. I'll incorporate the doc changes in a follow-up PR to avoid another CI.

@varunagrawal
Copy link
Collaborator

Thanks for the review. I'll incorporate the doc changes in a follow-up PR to avoid another CI.

I recommend doing it here so that it's all together if we ever have to come back to this PR. The cost of an extra CI run is not as bad as training LLMs these days. :)

@dellaert
Copy link
Member Author

Thanks for the review. I'll incorporate the doc changes in a follow-up PR to avoid another CI.

I recommend doing it here so that it's all together if we ever have to come back to this PR. The cost of an extra CI run is not as bad as training LLMs these days. :)

I already did it in a follow up PR. Please approve so I can move on

dellaert added a commit that referenced this pull request Jan 24, 2025
@dellaert dellaert merged commit cfb9ea7 into develop Jan 24, 2025
35 checks passed
@dellaert dellaert deleted the fix/refactor_marginals branch January 24, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants