Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Documentation: Update for Conway ledger era #1384

Merged

Conversation

CarlosLopezDeLara
Copy link
Collaborator

@CarlosLopezDeLara CarlosLopezDeLara commented Jan 17, 2025

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Please complete a Checklist
  2. Fill in all sections of the template
  3. Click "Create pull request"

Checklist

<-- Please fill the boxes with [x] before submitting a pull request -->

Updating documentation or Bugfix

This one updates guides and tutorials to use conway instead of babbage. And updates some commands that have changes in the cardano-cli.

@rphair rphair changed the title Carlos/updatequeries CLI Documentation: Update for Conway ledger era Jan 18, 2025
@rphair rphair added the documentation Improvements or additions to documentation label Jan 18, 2025
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very welcome & timely update, with other noteworthy fixes & cleanup.

@CarlosLopezDeLara if you are not going to fill out any part of the Pull Request template or provide a PR title, you might as well delete the template content... or even better, replace it with a summary of the PR rather than leaving its interpretation to the reviewer.

@CarlosLopezDeLara
Copy link
Collaborator Author

Very welcome & timely update, with other noteworthy fixes & cleanup.

@CarlosLopezDeLara if you are not going to fill out any part of the Pull Request template or provide a PR title, you might as well delete the template content... or even better, replace it with a summary of the PR rather than leaving its interpretation to the reviewer.

Sorry. missed that! Fixed now.

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@katomm katomm merged commit c7d7995 into cardano-foundation:staging Jan 22, 2025
3 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the carlos/updatequeries branch January 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants