Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian emoji language #277

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

step0ne
Copy link
Contributor

@step0ne step0ne commented Dec 1, 2023

I have problem with 'й' and 'Й'. Trying to fix by adding this cases to adapt_emoji_name, but some emoji don't process by this function. So i fix this inplace in data_dict.py by replacing "й" to "и".
Can u create new release with Russian?

@cvzi
Copy link
Contributor

cvzi commented Dec 2, 2023

I see the problem with Й. It happens because Й can be described in two ways in Unicode:
As a single unicode point: Й as \u0419
and as two unicode points: И + ̆ as \u0418\u0306

The ̆ symbol is not matched by regular expression class \w.

You can add the ̆ symbol to the regular expression here:
https://github.com/carpedm20/emoji/blob/master/emoji/core.py#L24
Just insert \u0306 after the existing \u0303

And then you can keep the й and Й and it should work.

@step0ne
Copy link
Contributor Author

step0ne commented Dec 4, 2023

I had fixed this problem. Thanks for comment😊
Could you make code review? And if it possible to make new version off library?

@cvzi
Copy link
Contributor

cvzi commented Dec 4, 2023

Looks good to me!

@TahirJalilov you can merge and release a new version

@TahirJalilov
Copy link
Collaborator

@step0ne Thank you for your PR.
And of course, thank you @cvzi for everything you do for this project ))

@TahirJalilov TahirJalilov merged commit 1846483 into carpedm20:master Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants