Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status for Recommendation CR #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mszostok
Copy link

Description

  • Update the Recommendation CR struct to include the new status field.

    apiVersion: autoscaling.cast.ai/v1
    kind: Recommendation
    metadata:
      generation: 1
      name: conditional-exit-deployment-deployment
      namespace: default
    spec:
      recommendation:
      - containerName: conditional-container
        requests:
          cpu: 10m
          memory: 10Mi
      targetRef:
        kind: Deployment
        name: conditional-exit-deployment
    status:
      conditions:
        - lastTransitionTime: "2025-01-29T14:23:46Z"
          message: 'The recommendation wasn''t applied immediately as it would create
            a new ReplicaSet. Multiple old ReplicaSets exceeding the history limit suggest
            possible misconfiguration—please review your settings (max allowed: 12, got:
            13).'
          observedGeneration: 1
          reason: SafeguardTriggered
          status: "False"
          type: Healthy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants