Remove -Inf from sales.mydec
#697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Very tricky bug, thanks! For context, the R docs explain why the maximum of an empty set is -Inf:
The minimum and maximum of a numeric empty set are
+Infand-Inf(in this order!) which ensures transitivity, e.g.,min(x1, min(x2))==min(x1, x2).
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have ~150
-Infvalues for the senior homestead exemption that are introduced by taking the max exemption values within sales in the mydec data when there are onlyNULLs:This didn't use to be an issue, but apparently the mydec data has some rows with NULL for exemption values now.
This PR makes sure any
-Infvalues are re-coded back to NULL for all exemption columns.