Add raw price threshold for sales val #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnerlmichael
commented
Jan 3, 2025
| @@ -178,6 +178,7 @@ def classify_outliers(df, stat_groups: list, min_threshold): | |||
| "sv_ind_ptax_flag_w_high_price_sqft": "High price per square foot", | |||
| "sv_ind_price_low_price_sqft": "Low price per square foot", | |||
| "sv_ind_ptax_flag_w_low_price_sqft": "Low price per square foot", | |||
| "sv_ind_raw_price_threshold": "Raw price threshold", | |||
There was a problem hiding this comment.
Assigning this reason with priority right after the other price flags that are generated with the statistical flagging groups.
Order of assignment between the three outlier reasons will be
- Price outlier
- Raw price outlier (this cap)
- Ptax
- Other char reasons
wagnerlmichael
commented
Jan 3, 2025
| @@ -807,6 +807,10 @@ def outlier_type(df: pd.DataFrame, condos: bool) -> pd.DataFrame: | |||
| "sv_ind_price_low_price_sqft", | |||
| ] | |||
|
|
|||
| # Implement raw threshold, unlog price | |||
| price_conditions.append((10 ** df["meta_sale_price"]) > 15_000_000) | |||
There was a problem hiding this comment.
This value is pending a final decision
jeancochrane
approved these changes
Jan 3, 2025
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
wagnerlmichael
commented
Jan 6, 2025
| "min_group_thresh": [min_group_thresh], | ||
| "raw_price_thresh": [raw_price_thresh], | ||
| "short_term_owner_threshold": [short_term_threshold], | ||
| "min_group_thresh": [min_group_threshold], |
There was a problem hiding this comment.
This min_group_thresh should eventually be migrated to min_group_threshold to maintain naming style.
jeancochrane
approved these changes
Jan 6, 2025
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current methodology, a sale with a price of 10 billion could make it into the model. This is because the statistical groups sales val uses to flag sales automatically include the sales if its group has less than 30 sales. We add a cap that automatically disqualifies sales regardless of the group threshold.
We also standardize instances of "thresh" naming to "threshold"