Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyword arg #145

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix keyword arg #145

merged 1 commit into from
Jan 22, 2025

Conversation

wagnerlmichael
Copy link
Member

@wagnerlmichael wagnerlmichael commented Jan 21, 2025 •
edited
Loading

We forgot to update a keyword arg when we did some standardizing of naming.

@wagnerlmichael wagnerlmichael marked this pull request as ready for review January 21, 2025 21:54
jeancochrane
jeancochrane approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

@wagnerlmichael wagnerlmichael merged commit f538c19 into main Jan 22, 2025
2 checks passed
@wagnerlmichael wagnerlmichael deleted the fix-df_parameter-keyword-arg-name branch January 22, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeancochrane jeancochrane jeancochrane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnerlmichael @jeancochrane