Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for rtl template content #1968

Merged
merged 37 commits into from
Oct 22, 2024
Merged

Add option for rtl template content #1968

merged 37 commits into from
Oct 22, 2024

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented Oct 8, 2024

Summary | Résumé

This PR adds the option of RTL template content behind a feature flag (FF_RTL).

When enabled, the content of the template will be right aligned in the preview and the email itself.

Test instructions | Instructions pour tester la modification

  • Ensure content aligns as expected in preview
  • Ensure content aligns as expected in received email

Copy link

github-actions bot commented Oct 8, 2024

@andrewleith andrewleith requested a review from whabanks October 17, 2024 15:25
@andrewleith andrewleith marked this pull request as ready for review October 17, 2024 15:54
@andrewleith andrewleith changed the title Feat/add rtl templates Add option for rtl template content Oct 17, 2024
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
✅ Renders RTL in preview & email
✅ Editing a RTL template preserves the RTL editing
✅ FF hides all RTL functionality in the UI

@andrewleith andrewleith merged commit 1d8c95d into main Oct 22, 2024
11 checks passed
@andrewleith andrewleith deleted the feat/add-rtl-templates branch October 22, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants