Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followed through some tailwind migration guides items. #2047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amazingphilippe
Copy link
Contributor

Summary | Résumé

Noticed some bugs with outlines and backgound images after migrating to tailwind 3. This made me revisit their migration guides (1 to 2 and 2 to 3)

I've found some important changes that we needed to fix:

  • purgecss isn't included above tw2 --- I've used their safelist config technique, but ideally we should stop using dynamic classes. (Eg. class="bg-{color}", where we feed in a "color" somewhere else)
  • no-wrap --- becomes nowrap
  • outlines and focus rings are kind of different. --- I've resorted to tweaking our main focus css so that our focus ring stays more consistent with what we had previously. Its a tad thicker, but at least I removed the outline offset.

Test instructions | Instructions pour tester la modification

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant