Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback gc-organisations data to the repo #2061

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

smcmurtry
Copy link
Contributor

Summary | Résumé

This PR adds fallback gc-organisations data to the repo. I used this datafile: https://github.com/cds-snc/gc-organisations/blob/main/data/all.json

This will be used if we are unable to connect to S3 or if any other exception occurs while trying to fetch this data.

Test instructions | Instructions pour tester la modification

  1. check out branch
  2. remove GC_ORGANISATIONS_BUCKET_NAME from your .env file if you have it
  3. run admin and api locally
  4. verify that you can create a new service and that the organisations are showing up in the dropdown on step 3

Copy link

@smcmurtry smcmurtry merged commit 0405222 into main Jan 29, 2025
11 checks passed
@smcmurtry smcmurtry deleted the feat/gc-org-fallback branch January 29, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants