Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and add to system config diagnostics #1590

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Jan 23, 2025

This adds a few more outputs (most importantly, the type of openmp configuration) and refactors the config diagnostic output for improved simplicity. ("Use" is now a set of all enabled options. The new config looks like:

{
  "config": {
    "build_type": "debug,shared",
    "core_geo": "ORANGE",
    "core_rng": "xorwow",
    "debug": true,
    "gpu_architectures": "",
    "hostname": "...",
    "openmp": "disabled",
    "real_type": "double",
    "units": "CGS",
    "use": [
      "geant4",
      "hepmc3",
      "root"
    ],
    "versions": {
      "CLHEP": "2.4.7.1",
      "Geant4": "11.0.4",
      "HepMC3": "3.03.00",
      "ROOT": "6.32.06"
    }
  }
}

compared to:

  "config": {
    "CELERITAS_BUILD_TYPE": "debug,shared",
    "CELERITAS_CORE_GEO": "ORANGE",
    "CELERITAS_CORE_RNG": "xorwow",
    "CELERITAS_DEBUG": true,
    "CELERITAS_HOSTNAME": "Goldfinger-4",
    "CELERITAS_REAL_TYPE": "double",
    "CELERITAS_UNITS": "CGS",
    "CELERITAS_USE_CUDA": false,
    "CELERITAS_USE_GEANT4": true,
    "CELERITAS_USE_HEPMC3": true,
    "CELERITAS_USE_HIP": false,
    "CELERITAS_USE_MPI": false,
    "CELERITAS_USE_OPENMP": false,
    "CELERITAS_USE_ROOT": true,
    "CELERITAS_USE_VECGEOM": false,
    "CLHEP_VERSION": "2.4.7.1",
    "Geant4_VERSION": "11.0.4"
  }

Note that for backward compatibility, this leaves the old config to peacefully coexist with the new (to be removed at the 0.6 release).

@sethrj sethrj requested a review from esseivaju January 23, 2025 20:02
@sethrj sethrj added enhancement New feature or request core Software engineering infrastructure labels Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Test summary

 4 478 files   6 904 suites   15m 33s ⏱️
 1 693 tests  1 687 ✅  6 💤 0 ❌
24 231 runs  24 147 ✅ 84 💤 0 ❌

Results for commit 929f52e.

♻️ This comment has been updated with latest results.

@sethrj sethrj requested a review from amandalund January 24, 2025 15:32
src/corecel/io/BuildOutput.cc Outdated Show resolved Hide resolved
@sethrj sethrj enabled auto-merge (squash) January 24, 2025 17:16
@sethrj sethrj merged commit d1498bb into celeritas-project:develop Jan 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants