Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update datasets with obsm keys that fail Seurat 5 regex requirements #708

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

nayib-jose-gloria
Copy link
Contributor

In response to missed, new seurat v5 requirement to only allow obsm embedding keys to begin with a letter (and begin with a letter after the "X_" prefix, if found).

Adds new transformation to datasets in affected collection to use different obsm key that fits Seurat regex requirements.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2a6e60e) 84.12% compared to head (be15dce) 84.14%.

Files Patch % Lines
cellxgene_schema_cli/cellxgene_schema/migrate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   84.12%   84.14%   +0.01%     
==========================================
  Files          19       19              
  Lines        1871     1873       +2     
==========================================
+ Hits         1574     1576       +2     
  Misses        297      297              
Flag Coverage Δ
unittests 84.14% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayib-jose-gloria nayib-jose-gloria merged commit 1f24b10 into main Dec 13, 2023
7 of 8 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/seurat-5-fix branch December 13, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants