Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows_http_acl in a language agnostic way using Windows-API #381

Closed
wants to merge 5 commits into from

Conversation

maltewitt
Copy link

Description

Getting the current URL ACL reservations is now implemented via Windows API (using FFI). The result no longer depends on the language-specific output of netsh.exe

Issues Resolved

#379

Check List

@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@maltewitt
Copy link
Author

The reason for travis-ci failing is the missing httpapi lib, which is part of the Windows-API and only available on windows systems. IMHO this seems to be fine for the windows cookbook.
What is the best way to satisfy travis-ci anyways? Is there some best common practice?

@mwrock
Copy link
Contributor

mwrock commented Jul 23, 2016

This is definitely the right direction here. I think you may be able to eliminate alot of the FFI mappings because many already exist in chef core. Have a look at the classes in https://github.com/chef/chef/tree/master/lib/chef/win32/api. Not all is there but probably most.

Regarding travis, typically we just dont run windows native stuff in travis. In this case it would be good to do something like this:

include Windows::UrlAcl if Chef::Platform.windows?

@tas50
Copy link
Contributor

tas50 commented Jan 3, 2017

@maltewitt Can you rebase this PR?

@tas50 tas50 closed this Aug 9, 2018
@tas50
Copy link
Contributor

tas50 commented Aug 9, 2018

Closing this out since we never heard back on the rebase. This is certainly something we'd like to take in. We've done similar conversions to FFI in the past and generally we do the FFI work in a gem, but this is part way towards that end goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants