Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve sonarcloud warnings #49

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Conversation

christianhelle
Copy link
Owner

  • use isinstance() for direct type comparison
  • Specify return types
  • Use assertIn instead of assertTrue

@christianhelle christianhelle self-assigned this Oct 19, 2024
@christianhelle christianhelle added the enhancement New feature or request label Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.96%. Comparing base (000f7e7) to head (abb1dd2).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/autofaker/generator.py 0.00% 1 Missing ⚠️
tests/test_create_anonymous_builtins.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   97.96%   97.96%   -0.01%     
==========================================
  Files          46       46              
  Lines        2508     2506       -2     
==========================================
- Hits         2457     2455       -2     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@christianhelle christianhelle merged commit f2906bc into main Oct 19, 2024
40 of 43 checks passed
@christianhelle christianhelle deleted the resolve-sonarcloud-warnings branch October 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant