Ensure that temporary records are not removed by the import script #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankhereford
commented
May 6, 2024
There was a problem hiding this comment.
Removing the two functions we're not calling anymore.
frankhereford
commented
May 6, 2024
Comment on lines
-672
to
-686
| try: | ||
| # this seemingly violates the principal of treating each record source equally, however, this is | ||
| # really only a reflection that we create incomplete temporary records consisting only of a crash record | ||
| # and not holding place entities for units, persons, etc. | ||
| if table == "crash" and util.has_existing_temporary_record(pg, source["case_id"]): | ||
| print("\b🛎: " + str(source["crash_id"]) + " has existing temporary record") | ||
| time.sleep(5) | ||
| util.remove_existing_temporary_record(pg, source["case_id"]) | ||
| except: | ||
| # Trap the case of a missing case_id key error in the RealDictRow object. | ||
| # A RealDictRow, returned by the psycopg2 cursor, is a dictionary-like object, | ||
| # but lacks has_key() and other methods. | ||
| print("Skipping checking on existing temporary record for " + str(source["crash_id"])) | ||
| pass | ||
|
|
There was a problem hiding this comment.
This is the core of the PR; dropping this whole try/except which used to check for and remove temp records.
frankhereford
commented
May 6, 2024
Comment on lines
-730
to
+715
| if file.endswith(".xml"): | ||
| if file.endswith(".xml") or file == "crashReports": |
There was a problem hiding this comment.
I'm cherry picking this into this PR from the S3 one because some exports I have floating around (and we all will or already do) which have the PDF containing folder in them, and this checks for that so they don't treated like CSVs. This let me keep using the same test extract from the rest of my work today, and makes it safe for you to pick any you have laying around as well.
frankhereford
requested review from
chiaberry,
johnclary,
tillyw,
mddilley and
roseeichelmann
mddilley
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
This PR aims to close cityofaustin/atd-data-tech#17143.
Testing
Test this one locally by:
graphql-engineendpoint running.development_extractsfolder inside the CRIS import folder.Ship list