Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.8.x] Use Confluent package for DosFilter #1345

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

mattwong949
Copy link
Member

rest-utils is updating the 7.8.x branch to include changes to DosFilter - confluentinc/rest-utils#535

this PR resolves build errors that would've occurred

@mattwong949 mattwong949 requested review from a team as code owners January 30, 2025 19:06
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Contributor

@shubh-ranade shubh-ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shubh-ranade
Copy link
Contributor

shubh-ranade commented Jan 31, 2025

@mattwong949 it seems kafka-rest 7.8.x uses rest-utils 7.8.1. I think cherry picking confluentinc/rest-utils#535 to rest-utils 7.8.1 should fix the build of this PR.

I'm not sure why this PR build is working. CP jar build failed but I'm not sure if it's because of the above. Is it possible that .x branches always use corresponding .x branches regardless of what's in pom?

cc: @trnguyencflt

@mattwong949 mattwong949 merged commit acc4b58 into 7.8.x Jan 31, 2025
1 of 2 checks passed
@mattwong949 mattwong949 deleted the mwong-jetty-upgrade-7.8 branch January 31, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants