Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/run policy add - support different service names #3748

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

numcys
Copy link
Contributor

@numcys numcys commented Nov 4, 2024

What is the feature/fix?

Fix for convox run supporting different service names with policies support.

@numcys numcys requested a review from nightfury1204 November 4, 2024 17:22
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.14%. Comparing base (aa14544) to head (4fc0d38).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/aws/processes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3748   +/-   ##
=======================================
  Coverage   33.14%   33.14%           
=======================================
  Files         182      182           
  Lines       20558    20558           
=======================================
  Hits         6814     6814           
  Misses      12596    12596           
  Partials     1148     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightfury1204 nightfury1204 merged commit abfbd77 into master Nov 4, 2024
3 of 4 checks passed
@nightfury1204 nightfury1204 deleted the fix/run-policy-add branch November 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants