Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase function to auto populate course collection #871

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elizabeth-tang
Copy link
Collaborator

Summary

This pull request is meant to help automatically populate the course collection every semester instead of manually running the script

  • Uses a built-in firebase cloud function

Remaining TODOs:

  • Change frequency to every semester -- currently runs every 5 minutes for testing purposes

Test Plan

  • ad hoc testing -- see if the courses are repopulated every 5 min and logs that it worked to firebase

@elizabeth-tang elizabeth-tang requested a review from a team as a code owner November 13, 2023 00:13
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 13, 2023

[diff-counting] Significant lines: 24.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Visit the preview URL for this PR (updated for commit e7cb5c3):

https://cornelldti-courseplan-dev--pr871-automate-course-coll-8g5j8wgy.web.app

(expires Wed, 03 Jan 2024 05:08:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear; this is not currently running every five minutes right?

@elizabeth-tang
Copy link
Collaborator Author

Just to be clear; this is not currently running every five minutes right?

Yep :)

Copy link
Collaborator

@zachary-kent zachary-kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a separate directory called functions with its own package.json? You can then install the firebase-functions dependency there. I think adding firebase-functions as a dependency caused another peer dependency to be bumped as well, causing the failing checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants