-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebase function to auto populate course collection #871
base: main
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 24. |
Visit the preview URL for this PR (updated for commit e7cb5c3): https://cornelldti-courseplan-dev--pr871-automate-course-coll-8g5j8wgy.web.app (expires Wed, 03 Jan 2024 05:08:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear; this is not currently running every five minutes right?
Yep :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a separate directory called functions
with its own package.json
? You can then install the firebase-functions
dependency there. I think adding firebase-functions
as a dependency caused another peer dependency to be bumped as well, causing the failing checks.
Summary
This pull request is meant to help automatically populate the course collection every semester instead of manually running the script
Remaining TODOs:
Test Plan