Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testcontainers for Java: Add showcase examples for different scenarios #54
Testcontainers for Java: Add showcase examples for different scenarios #54
Changes from 6 commits
a6287c4
b03974d
310f397
4f59167
507c898
1f4f08c
32fb516
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I miss something or the
discovery-type
option is not passed to the JdbcDatabaseContainer ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up.
In this particular case, outlining basic examples only, CrateDB will also happily start without any options, right? So it would be acceptable to omit the
-Cdiscovery.type=single-node
option?However, propagating command-line options to CrateDB will become important when aiming to use this in a multi-node scenario like what crate-java-testing provides per
CrateTestCluster
1, right? Did you already take this into account, @matriv, or would this be up to a second iteration?Footnotes
See also https://github.com/crate/crate-jdbc/issues/377. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, it goes ahead with a "best-effort cluster bootstrapping" and it works.