feat: Add user report endpoints support #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2025 16:45
* Implement list, add, get, delete and edit methods for User Report Settings. * Ensure compatibility with existing Report Settings logic.
* Added methods to handle User Report Settings Templates endpoints, reusing logic from existing Report Settings Templates methods. * Implemented tests to ensure the correct functionality of the newly added methods. * Created 4 JSON files for User Report Settings Templates, following the structure of existing Report Settings Templates.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
============================================
+ Coverage 93.97% 94.00% +0.03%
- Complexity 796 801 +5
============================================
Files 190 190
Lines 2685 2698 +13
Branches 54 54
============================================
+ Hits 2523 2536 +13
Misses 136 136
Partials 26 26 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for the
User Report Settings Templatesendpoints. For implementation I focused on reusing the existingReport Settings Templateslogic and made the necessary adjustments to handle the user-specific endpoints.Changes
User Report Settings Templatesendpoints (List,Add,Get,Delete,Edit).Report Settings Templatecode, with changes to theURLsandparameters.JSONfiles for theUser Report Settings Templates, structured after the existingReport Settings Templatefiles.Testing
Addtest method, I set (in the body of method) theisPublictonullsince is not part ofUser Templates.Additional notes
Report Settings Templaterather than creating a new class since on the documentation I've noticed that the responses (of each template) are quite similar in structure.JSONsassociated withReport Settings Templatewere a bit modified in comparison with the documentation, so I structured theUser Reportfiles based on them.